[llvm] r342154 - [cmake] Fix missing DEPENDS.

[Richard Diamond via llvm-commits]

On Thu, Sep 13, 2018 at 12:19 PM Roman Lebedev <lebedev.ri at gmail.com> wrote:

> Richard, why are you making non-NFC cmake changes with no review all
> over the place?
>

I apologize. I was informed by Chris (beanz) that the `llvm-cfi-verify`/etc
changes could be pushed without review. The second patch was to fix an
error on my part (missing `intrinsics_gen` in a target's DEPENDS) which
blew up the bots.

>
> On Thu, Sep 13, 2018 at 8:10 PM, Richard Diamond via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Author: diamond
> > Date: Thu Sep 13 10:10:44 2018
> > New Revision: 342154
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=342154&view=rev
> > Log:
> > [cmake] Fix missing DEPENDS.
> >
> > Not sure how I didn't catch this.
> >
> > Modified:
> >     llvm/trunk/tools/llvm-exegesis/CMakeLists.txt
> >     llvm/trunk/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt
> >     llvm/trunk/tools/llvm-exegesis/lib/CMakeLists.txt
> >     llvm/trunk/tools/llvm-exegesis/lib/X86/CMakeLists.txt
> >
> > Modified: llvm/trunk/tools/llvm-exegesis/CMakeLists.txt
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/CMakeLists.txt?rev=342154&r1=342153&r2=342154&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/tools/llvm-exegesis/CMakeLists.txt (original)
> > +++ llvm/trunk/tools/llvm-exegesis/CMakeLists.txt Thu Sep 13 10:10:44
> 2018
> > @@ -6,6 +6,9 @@ set(LLVM_LINK_COMPONENTS
> >
> >  add_llvm_tool(llvm-exegesis
> >    llvm-exegesis.cpp
> > +
> > +  DEPENDS
> > +  intrinsics_gen
> >    )
> >
> >  add_subdirectory(lib)
> >
> > Modified: llvm/trunk/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt?rev=342154&r1=342153&r2=342154&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt (original)
> > +++ llvm/trunk/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt Thu Sep 13
> 10:10:44 2018
> > @@ -8,6 +8,9 @@ add_llvm_library(LLVMExegesisAArch64
> >
> >    STATIC
> >
> > +  DEPENDS
> > +  intrinsics_gen
> > +
> >    LINK_COMPONENTS
> >    AArch64
> >    Exegesis
> >
> > Modified: llvm/trunk/tools/llvm-exegesis/lib/CMakeLists.txt
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/lib/CMakeLists.txt?rev=342154&r1=342153&r2=342154&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/tools/llvm-exegesis/lib/CMakeLists.txt (original)
> > +++ llvm/trunk/tools/llvm-exegesis/lib/CMakeLists.txt Thu Sep 13
> 10:10:44 2018
> > @@ -29,6 +29,9 @@ add_llvm_library(LLVMExegesis
> >
> >    STATIC
> >
> > +  DEPENDS
> > +  intrinsics_gen
> > +
> >    LINK_COMPONENTS
> >    Analysis
> >    CodeGen
> >
> > Modified: llvm/trunk/tools/llvm-exegesis/lib/X86/CMakeLists.txt
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/lib/X86/CMakeLists.txt?rev=342154&r1=342153&r2=342154&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/tools/llvm-exegesis/lib/X86/CMakeLists.txt (original)
> > +++ llvm/trunk/tools/llvm-exegesis/lib/X86/CMakeLists.txt Thu Sep 13
> 10:10:44 2018
> > @@ -8,6 +8,9 @@ add_llvm_library(LLVMExegesisX86
> >
> >    STATIC
> >
> > +  DEPENDS
> > +  intrinsics_gen
> > +
> >    LINK_COMPONENTS
> >    X86
> >    Exegesis
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180913/f2f440ad/attachment.html>