<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, Sep 13, 2018 at 12:19 PM Roman Lebedev <<a href="mailto:lebedev.ri@gmail.com">lebedev.ri@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Richard, why are you making non-NFC cmake changes with no review all<br>
over the place?<br></blockquote><div><br></div><div>I apologize. I was informed by Chris (beanz) that the `llvm-cfi-verify`/etc changes could be pushed without review. The second patch was to fix an error on my part (missing `intrinsics_gen` in a target's DEPENDS) which blew up the bots.</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On Thu, Sep 13, 2018 at 8:10 PM, Richard Diamond via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: diamond<br>
> Date: Thu Sep 13 10:10:44 2018<br>
> New Revision: 342154<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=342154&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=342154&view=rev</a><br>
> Log:<br>
> [cmake] Fix missing DEPENDS.<br>
><br>
> Not sure how I didn't catch this.<br>
><br>
> Modified:<br>
>     llvm/trunk/tools/llvm-exegesis/CMakeLists.txt<br>
>     llvm/trunk/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt<br>
>     llvm/trunk/tools/llvm-exegesis/lib/CMakeLists.txt<br>
>     llvm/trunk/tools/llvm-exegesis/lib/X86/CMakeLists.txt<br>
><br>
> Modified: llvm/trunk/tools/llvm-exegesis/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/CMakeLists.txt?rev=342154&r1=342153&r2=342154&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/CMakeLists.txt?rev=342154&r1=342153&r2=342154&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/tools/llvm-exegesis/CMakeLists.txt (original)<br>
> +++ llvm/trunk/tools/llvm-exegesis/CMakeLists.txt Thu Sep 13 10:10:44 2018<br>
> @@ -6,6 +6,9 @@ set(LLVM_LINK_COMPONENTS<br>
><br>
>  add_llvm_tool(llvm-exegesis<br>
>    llvm-exegesis.cpp<br>
> +<br>
> +  DEPENDS<br>
> +  intrinsics_gen<br>
>    )<br>
><br>
>  add_subdirectory(lib)<br>
><br>
> Modified: llvm/trunk/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt?rev=342154&r1=342153&r2=342154&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt?rev=342154&r1=342153&r2=342154&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt (original)<br>
> +++ llvm/trunk/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt Thu Sep 13 10:10:44 2018<br>
> @@ -8,6 +8,9 @@ add_llvm_library(LLVMExegesisAArch64<br>
><br>
>    STATIC<br>
><br>
> +  DEPENDS<br>
> +  intrinsics_gen<br>
> +<br>
>    LINK_COMPONENTS<br>
>    AArch64<br>
>    Exegesis<br>
><br>
> Modified: llvm/trunk/tools/llvm-exegesis/lib/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/lib/CMakeLists.txt?rev=342154&r1=342153&r2=342154&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/lib/CMakeLists.txt?rev=342154&r1=342153&r2=342154&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/tools/llvm-exegesis/lib/CMakeLists.txt (original)<br>
> +++ llvm/trunk/tools/llvm-exegesis/lib/CMakeLists.txt Thu Sep 13 10:10:44 2018<br>
> @@ -29,6 +29,9 @@ add_llvm_library(LLVMExegesis<br>
><br>
>    STATIC<br>
><br>
> +  DEPENDS<br>
> +  intrinsics_gen<br>
> +<br>
>    LINK_COMPONENTS<br>
>    Analysis<br>
>    CodeGen<br>
><br>
> Modified: llvm/trunk/tools/llvm-exegesis/lib/X86/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/lib/X86/CMakeLists.txt?rev=342154&r1=342153&r2=342154&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/lib/X86/CMakeLists.txt?rev=342154&r1=342153&r2=342154&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/tools/llvm-exegesis/lib/X86/CMakeLists.txt (original)<br>
> +++ llvm/trunk/tools/llvm-exegesis/lib/X86/CMakeLists.txt Thu Sep 13 10:10:44 2018<br>
> @@ -8,6 +8,9 @@ add_llvm_library(LLVMExegesisX86<br>
><br>
>    STATIC<br>
><br>
> +  DEPENDS<br>
> +  intrinsics_gen<br>
> +<br>
>    LINK_COMPONENTS<br>
>    X86<br>
>    Exegesis<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>