[PATCH] D51979: [llvm-exegesis][NFC] Split BenchmarkRunner class

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added inline comments.


================
Comment at: tools/llvm-exegesis/lib/SnippetGenerator.h:40
+// Common code for all benchmark modes.
+class SnippetGenerator {
+public:
----------------
courbet wrote:
> gchatelet wrote:
> > SnippetGeneratorBase?
> Users of the class manipulate it through the base class, so it would be a bit awkward to have functions take a `SnippetGeneratorBase` instead of a `SnippetGenerator`.
I see. Never mind then.


Repository:
  rL LLVM

https://reviews.llvm.org/D51979