[PATCH] D51979: [llvm-exegesis][NFC] Split BenchmarkRunner class
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 12 23:13:32 PDT 2018
courbet added a comment.
Thanks.
================
Comment at: tools/llvm-exegesis/lib/SnippetGenerator.h:40
+// Common code for all benchmark modes.
+class SnippetGenerator {
+public:
----------------
gchatelet wrote:
> SnippetGeneratorBase?
Users of the class manipulate it through the base class, so it would be a bit awkward to have functions take a `SnippetGeneratorBase` instead of a `SnippetGenerator`.
Repository:
rL LLVM
https://reviews.llvm.org/D51979
More information about the llvm-commits
mailing list