[PATCH] D51918: [Support] sys::fs::directory_entry includes the file_type.

via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 12 14:50:58 PDT 2018


Sam I don't have access to amend your revision, it might be related to you being an
administrator on Phab. Just sending you the patch for the Windows `Path.inc`.

On 12/09/2018 at 14:41 PM, "Kristina Brooks via Phabricator" <reviews at reviews.llvm.org> wrote:
>
>kristina added a comment.
>
>In https://reviews.llvm.org/D51918#1232477, @sammccall wrote:
>
>> In https://reviews.llvm.org/D51918#1232441, @kristina wrote:
>>
>> > Shall I just fix up the Windows stuff and add another diff if 
>you don't mind?
>>
>>
>> Thanks very much! I'm more reliant on my IDE than I thought!
>>
>> Please do upload a new version if it's not too much trouble (I 
>added one that might work, but I can't verify)
>
>
>I have a working patch with further format fixes but I can't seem 
>to be able to attach it to this revision. How would I do that?
>
>  PS Q:\BuildRoot\llvm-8.0-win32-oneshot\RelWithDebInfo\lib> Get-
>Item LLVMSu*
>      Directory: Q:\BuildRoot\llvm-8.0-win32-
>oneshot\RelWithDebInfo\lib
>  Mode                LastWriteTime         Length Name
>  ----                -------------         ------ ----
>  -a----       12/09/2018     14:14       17083534 LLVMSupport.lib
>
>
>Repository:
>  rL LLVM
>
>https://reviews.llvm.org/D51918
-------------- next part --------------
A non-text attachment was scrubbed...
Name: WindowsPathInc.diff
Type: application/octet-stream
Size: 51739 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180912/3a0faa9e/attachment.obj>


More information about the llvm-commits mailing list