[PATCH] D51918: [Support] sys::fs::directory_entry includes the file_type.

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 12 14:41:17 PDT 2018


kristina added a comment.

In https://reviews.llvm.org/D51918#1232477, @sammccall wrote:

> In https://reviews.llvm.org/D51918#1232441, @kristina wrote:
>
> > Shall I just fix up the Windows stuff and add another diff if you don't mind?
>
>
> Thanks very much! I'm more reliant on my IDE than I thought!
>
> Please do upload a new version if it's not too much trouble (I added one that might work, but I can't verify)


I have a working patch with further format fixes but I can't seem to be able to attach it to this revision. How would I do that?

  PS Q:\BuildRoot\llvm-8.0-win32-oneshot\RelWithDebInfo\lib> Get-Item LLVMSu*
      Directory: Q:\BuildRoot\llvm-8.0-win32-oneshot\RelWithDebInfo\lib
  Mode                LastWriteTime         Length Name
  ----                -------------         ------ ----
  -a----       12/09/2018     14:14       17083534 LLVMSupport.lib


Repository:
  rL LLVM

https://reviews.llvm.org/D51918





More information about the llvm-commits mailing list