[PATCH] D51753: [DAGCombiner] try to convert pow(x, 1/3) to cbrt(x)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 12 08:49:52 PDT 2018


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

Looks good, but would be good for someone else to take a look, too.



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp:181-183
   case ISD::FSQRT:                      return "fsqrt";
   case ISD::STRICT_FSQRT:               return "strict_fsqrt";
+  case ISD::FCBRT:                      return "fcbrt";
----------------
Will `strict_fcbrt` be needed, too?


https://reviews.llvm.org/D51753





More information about the llvm-commits mailing list