[PATCH] D51726: [AMDGPU] Remove non-instructions from GCNHazardRecognizer buffer

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added inline comments.


================
Comment at: lib/Target/AMDGPU/GCNHazardRecognizer.cpp:263-265
       unsigned Opcode = MI->getOpcode();
-      if (Opcode == AMDGPU::DBG_VALUE || Opcode == AMDGPU::IMPLICIT_DEF ||
-          Opcode == AMDGPU::INLINEASM)
+      if (Opcode == AMDGPU::INLINEASM)
         continue;
----------------
nhaehnle wrote:
> Please remove INLINEASM here, as well. A test case would be good as well.
> 
> There is no guarantee that inline assembly contains actual instructions, and in fact there are cases where Mesa currently generates fake inline assembly as a workaround.
Actually, scratch that, I got my wires crossed about the logic of this code. This part of it should be fine?

However, I think the point stands that the same issue that affects DBG_VALUEs with respect to the buffer can also affect inline assembly instructions.


https://reviews.llvm.org/D51726