[PATCH] D51726: [AMDGPU] Remove non-instructions from GCNHazardRecognizer buffer

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added inline comments.


================
Comment at: lib/Target/AMDGPU/GCNHazardRecognizer.cpp:263-265
       unsigned Opcode = MI->getOpcode();
-      if (Opcode == AMDGPU::DBG_VALUE || Opcode == AMDGPU::IMPLICIT_DEF ||
-          Opcode == AMDGPU::INLINEASM)
+      if (Opcode == AMDGPU::INLINEASM)
         continue;
----------------
Please remove INLINEASM here, as well. A test case would be good as well.

There is no guarantee that inline assembly contains actual instructions, and in fact there are cases where Mesa currently generates fake inline assembly as a workaround.


https://reviews.llvm.org/D51726