[PATCH] D51726: [AMDGPU] Remove non-instructions from GCNHazardRecognizer buffer

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/GCNHazardRecognizer.cpp:222
+  unsigned Opcode = CurrCycleInstr->getOpcode();
+  if (Opcode == AMDGPU::DBG_VALUE || Opcode == AMDGPU::IMPLICIT_DEF)
+    return;
----------------
isDebugInstr()


================
Comment at: test/CodeGen/AMDGPU/hazard-lookahead.mir:8-13
+name: hazard-lookahead-implicit-def
+body: |
+  ; GCN-LABEL: name: hazard-lookahead-implicit-def
+  ; GCN: $vgpr6 = IMPLICIT_DEF
+  ; GFX89: S_NOP 0
+  ; GCN: S_SENDMSG 3, implicit $exec, implicit $m0
----------------
We already have a test for implicit_def behavior in hazard.mir? You can merge this test into that one


================
Comment at: test/CodeGen/AMDGPU/hazard-lookahead.mir:38
+    DBG_VALUE 0
+    DBG_VALUE 1
+    DBG_VALUE 2
----------------
Need another test with DBG_LABEL


Repository:
  rL LLVM

https://reviews.llvm.org/D51726