[PATCH] D51443: [dsymutil] Remove non-determinism.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:316-317
+  else
+    Info.Prune &= Info.Ctxt && Info.Ctxt->getCanonicalDIEOffset() > 0 &&
+                  Info.Ctxt->getCanonicalDIEOffset() <= DefinitionOffset;
 
----------------
friss wrote:
> as you checked that DefinitionOffset is not 0, the first part of your condition seems unnecessary.
The size difference is marginal. I'll compute the actual value tomorrow, but it was less than a megabyte on an almost 1GB dSYM (for clang).


https://reviews.llvm.org/D51443