[PATCH] D51443: [dsymutil] Remove non-determinism.

[Frederic Riss via Phabricator via llvm-commits]

friss added a comment.

2 additional comments:

- DefinitionOffset is a horrible name. What about ModulesEndOffset?
- Did you answer Adrian's question about the size increase? Hopefully this is not a blocker, because I like the simplicity of this approach.



================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:316-317
+  else
+    Info.Prune &= Info.Ctxt && Info.Ctxt->getCanonicalDIEOffset() > 0 &&
+                  Info.Ctxt->getCanonicalDIEOffset() <= DefinitionOffset;
 
----------------
as you checked that DefinitionOffset is not 0, the first part of your condition seems unnecessary.


https://reviews.llvm.org/D51443