[PATCH] D51286: [IndVars] Fix usage of SCEVExpander to not mess with SCEVConstant. PR38674

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 3 20:21:26 PDT 2018


mkazantsev added a comment.

In https://reviews.llvm.org/D51286#1222271, @etherzhhb wrote:

> Is it possible to fix the problem by directly codegening the constant from SCEVConstant in expandSCEVIfNeeded?


What's the point of that? I generally don't see any profit in going manually into rewriting internals and trying to find something in its map. Expand methods are designed to handle such cases.


https://reviews.llvm.org/D51286





More information about the llvm-commits mailing list