[PATCH] D51286: [IndVars] Fix usage of SCEVExpander to not mess with SCEVConstant. PR38674

[Hongbin Zheng via Phabricator via llvm-commits]

etherzhhb added a comment.

LGTM in general.

So by removing expandSCEVIfNeeded, we now rely on gvn to eliminate the redundant code.

Maybe we could explain in the commit message:
Is mapping SCEVConstant to Instruction the only problem of expandSCEVIfNeeded?
Is it possible to fix the problem by directly codegening the constant from SCEVConstant in expandSCEVIfNeeded?


https://reviews.llvm.org/D51286