[PATCH] D50659: [CodeGen] Fix remaining zext() assertions in SelectionDAG
Scott Linder via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 31 09:38:36 PDT 2018
scott.linder added inline comments.
================
Comment at: unittests/CodeGen/SelectionDAGTest.cpp:39
+ if (!T)
+ return;
+
----------------
efriedma wrote:
> This seems bad; the test silently fails to run if the AArch64 target isn't built?
This does seem bad, but as far as I can tell there is no appealing alternative. Not that it absolves me of this, but other tests (e.g. CodeGen/GlobalISel/LegalizerHelperTest.h) do the same. The core issue is not having a "generic target" always available for unittests.
Is there anything better to do in this case?
Repository:
rL LLVM
https://reviews.llvm.org/D50659
More information about the llvm-commits
mailing list