[PATCH] D50659: [CodeGen] Fix remaining zext() assertions in SelectionDAG

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 30 17:28:06 PDT 2018


efriedma added a comment.

I guess this approach is okay, specifically for testing the SelectionDAG analysis helpers.



================
Comment at: unittests/CodeGen/SelectionDAGTest.cpp:39
+    if (!T)
+      return;
+
----------------
This seems bad; the test silently fails to run if the AArch64 target isn't built?


Repository:
  rL LLVM

https://reviews.llvm.org/D50659





More information about the llvm-commits mailing list