[PATCH] D51248: Support for remapping profile data, for sample-based profiling.

[Wei Mi via llvm-commits]

On Thu, Aug 30, 2018 at 9:44 AM, David Li via Phabricator <
reviews at reviews.llvm.org> wrote:

> davidxl added inline comments.
>
>
> ================
> Comment at: unittests/ProfileData/SampleProfTest.cpp:120
> +
> +    FunctionSamples *ReadFooSamples = Reader->getSamplesFor(FooName);
> +    ASSERT_TRUE(ReadFooSamples != nullptr);
> ----------------
> directly using raw name will break compact format testing.
>

Inside of getSamplesFor, FooName will be translated according to the
profile format. So using raw name will not break compact format testing.

I am doing a cleanup to make only the Reader/Writer/FunctionSamples classes
aware of the format. Currently the format checking scatters over the
SampleProfileLoaderPass.

Wei.


>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D51248
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180830/3767e353/attachment.html>