<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 30, 2018 at 9:44 AM, David Li via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">davidxl added inline comments.<br>
<br>
<br>
================<br>
</span>Comment at: unittests/ProfileData/<wbr>SampleProfTest.cpp:120<br>
+<br>
+    FunctionSamples *ReadFooSamples = Reader->getSamplesFor(FooName)<wbr>;<br>
+    ASSERT_TRUE(ReadFooSamples != nullptr);<br>
----------------<br>
directly using raw name will break compact format testing.<br></blockquote><div><br></div><div>Inside of <span style="font-size:small;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">getSamplesFor, FooName will be translated according to the profile format. So using raw name will not break compact format testing.</span></div><div><span style="font-size:small;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div><div><span style="font-size:small;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">I am doing a cleanup to make only the Reader/Writer/FunctionSamples classes aware of the format. Currently the format checking scatters over the SampleProfileLoaderPass.</span></div><div><span style="font-size:small;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div><div><span style="font-size:small;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Wei.</span></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="gmail-HOEnZb"><div class="gmail-h5"><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D51248" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D51248</a><br>
<br>
<br>
<br>
</div></div></blockquote></div><br></div></div>