[PATCH] D51465: Revamp test-suite documentation

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 30 09:47:46 PDT 2018


tra accepted this revision.
tra added a comment.

Looks great. Thank you for updating the docs.



================
Comment at: docs/TestSuiteGuide.rst:19-20
+
+        % svn co http://llvm.org/svn/llvm-project/llvm/trunk llvm
+        % sudo pip install llvm/utils/lit
+        # You can also install the tool manually if lit is not available:
----------------
kristof.beyls wrote:
> I tend to prefer documentation that shows how to set up a virtualenv, so that copy pasting commands from the documentation doesn't change your system set up by default.
> However, in this case, I can also see the argument to not do that and keep documentation more concise.
> 
> I'm happy either way - just thought I'd share my thought.
Is installing lit directly from llvm a hard requirement?
I've been using `pip install lit` and that appears to work.


Repository:
  rL LLVM

https://reviews.llvm.org/D51465





More information about the llvm-commits mailing list