[PATCH] D51465: Revamp test-suite documentation

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added a comment.

Thanks for investing time into the documentation



================
Comment at: docs/TestSuiteGuide.rst:55
+        Scanning dependencies of target fpcmp-host
+        [  0%] [TEST_SUITE_HOST_CC] Building host executable fpcmp
+        [  0%] Built target fpcmp-host
----------------
There will be no more `TEST_SUITE_HOST_CC` after D51080.


================
Comment at: docs/TestSuiteGuide.rst:224
+
+-  ``-C test-suite/cmake/caches/cachefile.cmake``
+
----------------
The file `cachefile.cmake` does not exist. Maybe use an existing example such as `Release.cmake` or use a wildcard/placeholder such as `<cachefile>.cmake`?


================
Comment at: docs/TestSuiteGuide.rst:309-316
+You can build custom suites using the test-suite infrastructure. They must have
+a ``CMakeLists.txt`` file at the top directory and will be picked up
+automatically if placed into a subdirectory of the test-suite or when setting
+the ``TEST_SUITE_SUBDIRS`` variable:
+
+    .. code-block:: bash
+
----------------
Maybe it is worth pointing out that one cannot point into arbitrary subdirs of SingleSource/MultSource/MicroBenchmarks/Bitcode since these have custom `lit.local.cfg` on their level.

(CTMark unfortunately skips MultiSource/lit.local.cfg)


================
Comment at: docs/TestSuiteGuide.rst:344
+
+Note: The ``TEST_SUITE_RUN_TYPE`` setting only affects the SPEC benchmark suite.
+
----------------
... SPEC benchmark suite**s**


Repository:
  rL LLVM

https://reviews.llvm.org/D51465