[PATCH] D51456: [LLD] [COFF] When doing automatic dll imports, replace whole .refptr.<var> chunks with __imp_<var>

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 29 22:08:30 PDT 2018


mstorsjo added inline comments.


================
Comment at: COFF/Chunks.h:189
 
+  void discard() { Live = false; }
+
----------------
ruiu wrote:
> Now `Live` member has both read and write accessors, so I'd make it a public member and remove this function and `isLive`.
Ok - what about the `markLive` function, should I remove that one as well? Or do we want to keep it for the sake of the asserts?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D51456





More information about the llvm-commits mailing list