[PATCH] D51456: [LLD] [COFF] When doing automatic dll imports, replace whole .refptr.<var> chunks with __imp_<var>

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/Chunks.h:189
 
+  void discard() { Live = false; }
+
----------------
Now `Live` member has both read and write accessors, so I'd make it a public member and remove this function and `isLive`.


================
Comment at: COFF/SymbolTable.cpp:173
+
+  DefinedRegular *Refptr =
+      dyn_cast_or_null<DefinedRegular>(find((".refptr." + Name).str()));
----------------
This probably needs comment as I believe this is hard to understand for those who don't know what the intention of this code is.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D51456