[PATCH] D44704: [GlobalISel][X86][ARM] Relaxing type constraints on G_SHL and friends

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: lib/Target/AArch64/AArch64InstructionSelector.cpp:1092
+  case TargetOpcode::G_ASHR:
+    llvm_unreachable("G_ASHR is expected to be tablegen-selectable");
+
----------------
aemerson wrote:
> Even though this may be true, I'd rather we not use unreachable here. If for some reason Tablegen fails to select the user we want to have SDAG try it.
s/select the user/select, for the user


Repository:
  rL LLVM

https://reviews.llvm.org/D44704