[PATCH] D44704: [GlobalISel][X86][ARM] Relaxing type constraints on G_SHL and friends

[Amara Emerson via Phabricator via llvm-commits]

aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.
Herald added subscribers: atanasyan, jvesely.

I'd like to get this in. LGTM but needs one issue addressed.



================
Comment at: lib/Target/AArch64/AArch64InstructionSelector.cpp:1092
+  case TargetOpcode::G_ASHR:
+    llvm_unreachable("G_ASHR is expected to be tablegen-selectable");
+
----------------
Even though this may be true, I'd rather we not use unreachable here. If for some reason Tablegen fails to select the user we want to have SDAG try it.


Repository:
  rL LLVM

https://reviews.llvm.org/D44704