[PATCH] D50894: Pull google/benchmark library to the LLVM tree

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/trunk/utils/benchmark/src/CMakeLists.txt:14
+    ${CMAKE_CURRENT_SOURCE_DIR}/*.h)
+list(FILTER SOURCE_FILES EXCLUDE REGEX "benchmark_main\\.cc")
+
----------------
a.elovikov wrote:
> That seems to require CMake 3.6 (https://stackoverflow.com/questions/42167432/cmake-list-does-not-recognize-sub-command-filter).
> 
> But our requirement is only 3.4.3 (https://llvm.org/docs/GettingStarted.html).
https://github.com/google/benchmark/commit/505be96ab23056580a3a2315abba048f4428b04e needs to be applied, too.


Repository:
  rL LLVM

https://reviews.llvm.org/D50894