[PATCH] D50894: Pull google/benchmark library to the LLVM tree

Andrei Elovikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 28 03:49:25 PDT 2018


a.elovikov added inline comments.


================
Comment at: llvm/trunk/utils/benchmark/src/CMakeLists.txt:14
+    ${CMAKE_CURRENT_SOURCE_DIR}/*.h)
+list(FILTER SOURCE_FILES EXCLUDE REGEX "benchmark_main\\.cc")
+
----------------
That seems to require CMake 3.6 (https://stackoverflow.com/questions/42167432/cmake-list-does-not-recognize-sub-command-filter).

But our requirement is only 3.4.3 (https://llvm.org/docs/GettingStarted.html).


Repository:
  rL LLVM

https://reviews.llvm.org/D50894





More information about the llvm-commits mailing list