[PATCH] D47179: [LLVM-C] Add Bindings For Named Metadata
Robert Widmann via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 27 10:21:43 PDT 2018
CodaFi added inline comments.
================
Comment at: include/llvm-c/Core.h:898
+ */
+const char *LLVMGetNamedMetadataName(LLVMNamedMDNodeRef NamedMD, size_t *NameLen);
+
----------------
Wallbraker wrote:
> Should this be disposed with LLVMDisposeMessage? Please update comment to reflect this.
No. In general, `Get`-named things return objects managed by somebody else. `Copy`-named things (or, unfortunately, functions documented to the contrary) return user-owned objects. In this case, the module owns the named metadata which owns its name.
https://reviews.llvm.org/D47179
More information about the llvm-commits
mailing list