[PATCH] D47179: [LLVM-C] Add Bindings For Named Metadata
Jakob Bornecrantz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 27 10:19:36 PDT 2018
Wallbraker added a comment.
The C-API changes looks good to me and the logic makes sense. Just one nit.
================
Comment at: include/llvm-c/Core.h:898
+ */
+const char *LLVMGetNamedMetadataName(LLVMNamedMDNodeRef NamedMD, size_t *NameLen);
+
----------------
Should this be disposed with LLVMDisposeMessage? Please update comment to reflect this.
https://reviews.llvm.org/D47179
More information about the llvm-commits
mailing list