[PATCH] D51249: Add flag to enable profile remapping to external interfaces to LLVM.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Transforms/IPO/SampleProfile.cpp:99
 
+static cl::opt<std::string> SampleProfileRemappingFile(
+    "sample-profile-remapping-file", cl::init(""), cl::value_desc("filename"),
----------------
add some brief description on what the remapping file is for.


================
Comment at: lib/Transforms/IPO/SampleProfile.cpp:1533
+  if (!RemappingFilename.empty()) {
+    ReaderOrErr = SampleProfileReaderItaniumRemapper::create(
+        RemappingFilename, Ctx, std::move(Reader));
----------------
Add a comment on what the Remapper does here. In particular, comment on the API name 'ItaniumRemapper' -- which will look very strange for maintainers without knowing the background.


Repository:
  rL LLVM

https://reviews.llvm.org/D51249