[llvm] r340678 - [MC, RISCV] Fixed StringRef Assertion `Index < Length && "Invalid index!"'

[Ana Pazos via llvm-commits]

Author: apazos
Date: Fri Aug 24 18:34:32 2018
New Revision: 340678

URL: http://llvm.org/viewvc/llvm-project?rev=340678&view=rev
Log:
[MC, RISCV] Fixed StringRef Assertion `Index < Length && "Invalid index!"'

Summary:
Handle the case IDVal is an empty string.

This bug was uncovered by a LLVM MC Assembler Protocol Buffer
Fuzzer  for the RISC-V assembly language.

Reviewers: rnk

Reviewed By: rnk

Subscribers: rnk, niravd, pcc, peter.smith, asb, grosbach, llvm-commits, bcain, kito-cheng, shiva0217, rogfer01, PkmX

Differential Revision: https://reviews.llvm.org/D50808

Added:
    llvm/trunk/test/Assembler/empty-string.s
Modified:
    llvm/trunk/lib/MC/MCParser/AsmParser.cpp

Modified: llvm/trunk/lib/MC/MCParser/AsmParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCParser/AsmParser.cpp?rev=340678&r1=340677&r2=340678&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCParser/AsmParser.cpp (original)
+++ llvm/trunk/lib/MC/MCParser/AsmParser.cpp Fri Aug 24 18:34:32 2018
@@ -1842,7 +1842,7 @@ bool AsmParser::parseStatement(ParseStat
   // Otherwise, we have a normal instruction or directive.
 
   // Directives start with "."
-  if (IDVal[0] == '.' && IDVal != ".") {
+  if (IDVal.startswith(".") && IDVal != ".") {
     // There are several entities interested in parsing directives:
     //
     // 1. The target-specific assembly parser. Some directives are target

Added: llvm/trunk/test/Assembler/empty-string.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Assembler/empty-string.s?rev=340678&view=auto
==============================================================================
--- llvm/trunk/test/Assembler/empty-string.s (added)
+++ llvm/trunk/test/Assembler/empty-string.s Fri Aug 24 18:34:32 2018
@@ -0,0 +1,3 @@
+// REQUIRES: riscv-registered-target
+// RUN: not llvm-mc -triple riscv32-unknown-linux-gnu < %s 2>&1 | FileCheck %s
+"" # CHECK: error: unrecognized instruction mnemonic