[PATCH] D46179: [X86] Lowering addus/subus intrinsics to native IR (LLVM part)

Steven Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 24 11:01:07 PDT 2018


srj added a comment.

In https://reviews.llvm.org/D46179#1212415, @spatel wrote:

> Would it help or hurt if we narrowed the select in IR to match the final return type and original operand types (I made the types smaller from your code just to make this easier to read):


Not sure I understand the question -- are you suggesting that this is code I should add, or that this is a transformation that LLVM would do under the hood?

If the former, I don't see how it would help, unless I made the function not-inlined (which would seem to compromise efficiency).

If the latter, I'm not qualified to answer as I know very little about the relevant internal bits of LLVM :-)


Repository:
  rL LLVM

https://reviews.llvm.org/D46179





More information about the llvm-commits mailing list