[llvm] r340561 - Fixup AreCoreFilesPrevented() to consider first LLVM_ENABLE_CRASH_DUMPS and secondly coreFilesPrevented.

[Reid Kleckner via llvm-commits]

My mistake, I think what I really meant to do was to change the default
value of coreFilesPrevented. I'll go ahead and do that.

On Thu, Aug 23, 2018 at 11:21 AM Douglas Yung via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: dyung
> Date: Thu Aug 23 11:20:13 2018
> New Revision: 340561
>
> URL: http://llvm.org/viewvc/llvm-project?rev=340561&view=rev
> Log:
> Fixup AreCoreFilesPrevented() to consider first LLVM_ENABLE_CRASH_DUMPS
> and secondly coreFilesPrevented.
>
> The previous change ignored the latter resulting in crash dumps being
> generated when LLVM_ENABLE_CRASH_DUMPS was
> set, but coreFilesPrevented was true.
>
> Modified:
>     llvm/trunk/lib/Support/Process.cpp
>
> Modified: llvm/trunk/lib/Support/Process.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Process.cpp?rev=340561&r1=340560&r2=340561&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Support/Process.cpp (original)
> +++ llvm/trunk/lib/Support/Process.cpp Thu Aug 23 11:20:13 2018
> @@ -87,7 +87,7 @@ static const char colorcodes[2][2][8][10
>  static bool coreFilesPrevented = false;
>
>  bool Process::AreCoreFilesPrevented() {
> -  return !LLVM_ENABLE_CRASH_DUMPS;
> +  return LLVM_ENABLE_CRASH_DUMPS ? coreFilesPrevented : false;
>  }
>
>  // Include the platform-specific parts of this class.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180823/48c9741d/attachment.html>