<div dir="ltr">My mistake, I think what I really meant to do was to change the default value of coreFilesPrevented. I'll go ahead and do that.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Aug 23, 2018 at 11:21 AM Douglas Yung via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dyung<br>
Date: Thu Aug 23 11:20:13 2018<br>
New Revision: 340561<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=340561&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=340561&view=rev</a><br>
Log:<br>
Fixup AreCoreFilesPrevented() to consider first LLVM_ENABLE_CRASH_DUMPS and secondly coreFilesPrevented.<br>
<br>
The previous change ignored the latter resulting in crash dumps being generated when LLVM_ENABLE_CRASH_DUMPS was<br>
set, but coreFilesPrevented was true.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Support/Process.cpp<br>
<br>
Modified: llvm/trunk/lib/Support/Process.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Process.cpp?rev=340561&r1=340560&r2=340561&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Process.cpp?rev=340561&r1=340560&r2=340561&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Support/Process.cpp (original)<br>
+++ llvm/trunk/lib/Support/Process.cpp Thu Aug 23 11:20:13 2018<br>
@@ -87,7 +87,7 @@ static const char colorcodes[2][2][8][10<br>
 static bool coreFilesPrevented = false;<br>
<br>
 bool Process::AreCoreFilesPrevented() {<br>
-  return !LLVM_ENABLE_CRASH_DUMPS;<br>
+  return LLVM_ENABLE_CRASH_DUMPS ? coreFilesPrevented : false;<br>
 }<br>
<br>
 // Include the platform-specific parts of this class.<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>