[PATCH] D51032: [ARM] Avoid injecting constant islands in movw+movt pairs on Windows

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 02:22:42 PDT 2018


mstorsjo added inline comments.


================
Comment at: test/CodeGen/ARM/constant-island-movwt.mir:885
+...
+
+# CHECK:          $r5 = t2MOVTi16 $r5, target-flags(arm-hi16) @.str.118, 14, $noreg
----------------
peter.smith wrote:
> Could there be a comment to say something like. Check that constant pool is not placed in between t2MOVi16 and t2MOVTi16  as Windows requires these to be consecutive?
Sure, I'll amend it locally with such a comment.


https://reviews.llvm.org/D51032





More information about the llvm-commits mailing list