[PATCH] D51032: [ARM] Avoid injecting constant islands in movw+movt pairs on Windows

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

Thanks for the test update, I've no further comments.



================
Comment at: test/CodeGen/ARM/constant-island-movwt.mir:885
+...
+
+# CHECK:          $r5 = t2MOVTi16 $r5, target-flags(arm-hi16) @.str.118, 14, $noreg
----------------
Could there be a comment to say something like. Check that constant pool is not placed in between t2MOVi16 and t2MOVTi16  as Windows requires these to be consecutive?


https://reviews.llvm.org/D51032