[PATCH] D50968: [AST] make a static local variable in a fuction hidden by -fvisibility-inlines-hidden visible

[Hiroshi Inoue via Phabricator via llvm-commits]

inouehrs added inline comments.


================
Comment at: lib/AST/Decl.cpp:1227
         if (Optional<Visibility> Vis = getExplicitVisibility(Var, computation))
           LV.mergeVisibility(*Vis, true);
       }
----------------
steven.zhang wrote:
> Is it better to do the check here ? At some condition, not merge the visibility.
I placed the check in the current position to catch the case if `Var->hasExternalStorage()` is not true.


https://reviews.llvm.org/D50968