[PATCH] D50968: [AST] make a static local variable in a fuction hidden by -fvisibility-inlines-hidden visible
Qing Shan Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 21 03:35:25 PDT 2018
steven.zhang added inline comments.
================
Comment at: lib/AST/Decl.cpp:1227
if (Optional<Visibility> Vis = getExplicitVisibility(Var, computation))
LV.mergeVisibility(*Vis, true);
}
----------------
Is it better to do the check here ? At some condition, not merge the visibility.
https://reviews.llvm.org/D50968
More information about the llvm-commits
mailing list