[PATCH] D50569: Change how we handle -wrap.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/test/ELF/wrap-plt.s:31
+// DISASM-NEXT: jmp    36
+// DISASM-NEXT: jmp    47
+
----------------
grimar wrote:
> grimar wrote:
> > I would reveal more information here to show where the `jmp`s are actually pointing to.
> > 
> > ```
> > // DISASM:       _start:
> > // DISASM-NEXT:   1002:       {{.*}}  jmp     41
> > // DISASM-NEXT:   1007:       {{.*}}  jmp     36
> > // DISASM-NEXT:   100c:       {{.*}}  jmp     47
> > 
> > // 0x1002 + 41 + 5 == 0x1030 <__wrap_foo at plt>
> > // 0x1007 + 36 + 5 == 0x1030 <__wrap_foo at plt>
> > // 0x100c + 47 + 5 == 0x1040 <_start at plt>
> > ```
> This was not addressed.
This test was not written by me, but honestly I think this is good enough.


https://reviews.llvm.org/D50569