[PATCH] D50569: Change how we handle -wrap.

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: lld/test/ELF/wrap-plt.s:31
+// DISASM-NEXT: jmp    36
+// DISASM-NEXT: jmp    47
+
----------------
grimar wrote:
> I would reveal more information here to show where the `jmp`s are actually pointing to.
> 
> ```
> // DISASM:       _start:
> // DISASM-NEXT:   1002:       {{.*}}  jmp     41
> // DISASM-NEXT:   1007:       {{.*}}  jmp     36
> // DISASM-NEXT:   100c:       {{.*}}  jmp     47
> 
> // 0x1002 + 41 + 5 == 0x1030 <__wrap_foo at plt>
> // 0x1007 + 36 + 5 == 0x1030 <__wrap_foo at plt>
> // 0x100c + 47 + 5 == 0x1040 <_start at plt>
> ```
This was not addressed.


https://reviews.llvm.org/D50569