[PATCH] D50828: Add profiling and canonicalization support to demangler nodes. No functionality change intended.

[Zachary Turner via llvm-commits]

Can’t we just use a base class with pure virtual methods, pass it to the
demangle function, implement this in clang, and pass null from libcxxabi?
Moving the whole thing to a header file seems kinda unfortunate.
On Thu, Aug 16, 2018 at 6:43 PM Richard Smith - zygoloid via Phabricator <
reviews at reviews.llvm.org> wrote:

> rsmith added a comment.
>
> I'm going to try to split this patch so it adds a generic visitation
> mechanism to the demangler AST, and introduce a separate layer that
> includes Support and builds profiling off the visitation mechanism. That
> seems like the only way out that meets everyone's acceptance criteria.
> However, I don't see any way to do that without moving all of the demangler
> to a public header in include/llvm (since the whole thing will need to be
> included from both the Demangle/ demangler and the profiling demangler).
> That header would only be included (and the templates in it instantiated)
> in two places in LLVM, but still, it'd be a 5000-line header file. If
> people are strongly opposed to that approach, please shout now!
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D50828
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180816/cd71b00c/attachment.html>