[PATCH] D50875: Move lib/Demangle under lib/Support. No functionality change intended.
Richard Smith - zygoloid via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 16 16:21:46 PDT 2018
rsmith added a comment.
In https://reviews.llvm.org/D50875#1203436, @zturner wrote:
> If the licensing issue is that libc++abi can't include code from Support, then it also can't include `Compiler.h`.
libc++abi has its own Compiler.h both before and after this change, so I believe that's a non-issue.
> Can we use dependency injection or something to get some hooks into the demangler that allow you to customize the behavior from Clang / LLVM, as described in https://reviews.llvm.org/D50828?
Potentially, yes, and Erik and I have discussed some ways to do that in the longer term. But I think the demangler belongs in Support regardless of whether or not we factor out that part.
Repository:
rL LLVM
https://reviews.llvm.org/D50875
More information about the llvm-commits
mailing list