[PATCH] D50875: Move lib/Demangle under lib/Support. No functionality change intended.
Chandler Carruth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 16 16:20:52 PDT 2018
chandlerc added a comment.
In https://reviews.llvm.org/D50875#1203430, @rsmith wrote:
> I removed the copy of Compiler.h from lib/Support/Demangle, because there is no longer any layering reason to not just use the version from include/llvm/Support. (libc++abi will still need its own Compiler.h.)
> I did not remove the StringView.h from lib/Support/Demangle, because the `StringView` class has a different interface from both `llvm::StringRef` and `std::string_view`, and keeping that file around to provide the interface that the demangling code wants seems like the best path for now. (libc++abi presumably can't depend on `std::string_view`, so needs its own implementation anyway.)
FWIW, I'd prefer that we make whatever libc++abi needs match the API of StringRef so that we can just have two modes for a single file, and leave the mini-StringRef-like thing in libc++abi....
Repository:
rL LLVM
https://reviews.llvm.org/D50875
More information about the llvm-commits
mailing list