[PATCH] D50828: Add profiling and canonicalization support to demangler nodes. No functionality change intended.

[Erik Pilkington via Phabricator via llvm-commits]

erik.pilkington added a subscriber: zturner.
erik.pilkington added a comment.

In https://reviews.llvm.org/D50828#1203312, @rsmith wrote:

> I think the only reasonable way to handle this is for `Demangle` to move into `Support`. We could keep the headers separate but move the implementation into `lib/Support/Demangle`, similar to what we do for `AST`. Or we could also move the headers to `include/llvm/Support/Demangle`. My preference is the latter; it seems reasonable to me for `Demangle` to generally live inside `Support`.


Sure, I really don't know why we didn't just do that to start with. The original RFC[1] talked about putting the demangler into Support, but the commit that materialized it (r280732) put Demangle into it's own library. Would be nice to get @zturner's sign-off for a move too, since he owns the microsoft demangler.

[1]: https://groups.google.com/forum/#!topic/llvm-dev/v_7OuWx8n1A


Repository:
  rL LLVM

https://reviews.llvm.org/D50828