[PATCH] D50828: Add profiling and canonicalization support to demangler nodes. No functionality change intended.

[Richard Smith - zygoloid via Phabricator via llvm-commits]

rsmith marked 2 inline comments as done.
rsmith added a comment.

In https://reviews.llvm.org/D50828#1203056, @erik.pilkington wrote:

> How are you handling the circular dependency problem? Support depends on Demangle, and with this patch Demangle would now depend on Support, right?


Good question. So far I've not handled that problem :(

I think the only reasonable way to handle this is for `Demangle` to move into `Support`. We could keep the headers separate but move the implementation into `lib/Support/Demangle`, similar to what we do for `AST`. Or we could also move the headers to `include/llvm/Support/Demangle`. My preference is the latter; it seems reasonable to me for `Demangle` to generally live inside `Support`.


Repository:
  rL LLVM

https://reviews.llvm.org/D50828