[PATCH] D50730: [AST] Generalize argument specific aliasing

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added a comment.

Thanks for the patch.



================
Comment at: include/llvm/Analysis/MemoryLocation.h:113
+                                       const TargetLibraryInfo *TLI);
+  static MemoryLocation getForArgument(ImmutableCallSite CS, unsigned ArgIdx,
+                                       const TargetLibraryInfo &TLI) {
----------------
Maybe just remove this function?


================
Comment at: lib/Analysis/AliasSetTracker.cpp:443
+    }
+    return;
+  }  
----------------
mkazantsev wrote:
> Aren't we supposed to return some value here?
the function returns void...


================
Comment at: lib/Analysis/MemoryLocation.cpp:162
   LibFunc F;
-  if (CS.getCalledFunction() && TLI.getLibFunc(*CS.getCalledFunction(), F) &&
-      F == LibFunc_memset_pattern16 && TLI.has(F)) {
+  if (CS.getCalledFunction() && TLI &&
+      TLI->getLibFunc(*CS.getCalledFunction(), F) &&
----------------
```
TLI && CS.getCalledFunction() && ....
```



Repository:
  rL LLVM

https://reviews.llvm.org/D50730