[PATCH] D50730: [AST] Generalize argument specific aliasing

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: lib/Analysis/AliasSetTracker.cpp:436
+        Access = AliasSet::RefAccess;
+      else if (!isRefSet(ArgMask) && isModSet(ArgMask))
+        Access = AliasSet::ModAccess;
----------------
How about 
  if (!isRefSet(ArgMask))
    Access = isModSet(ArgMask) ? AliasSet::ModAccess : AliasSet::NoAccess;



================
Comment at: lib/Analysis/AliasSetTracker.cpp:438
+        Access = AliasSet::ModAccess;
+      else if (!isRefSet(ArgMask) && !isModSet(ArgMask))
+        Access = AliasSet::NoAccess;
----------------
Looks more logical to set `NoAccess` as default and set `ModRefAccess` if both Ref and Mod are set, but it's up to you.


Repository:
  rL LLVM

https://reviews.llvm.org/D50730