[PATCH] D50708: [Tablegen][MCInstPredicate] Removed redundant template argument from class TIIPredicate, and implemented verification rules for TIIPredicates in CodeGenSchedule.cpp.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 14 11:28:43 PDT 2018


mattd added a comment.

In https://reviews.llvm.org/D50708#1199473, @andreadb wrote:

> Thanks for the review Matt.
>
> I noticed that I forgot to mark the new method 'const'. So I have decided to update the code review before committing it.


Even better.  LGTM.


https://reviews.llvm.org/D50708





More information about the llvm-commits mailing list