[PATCH] D50708: [Tablegen][MCInstPredicate] Removed redundant template argument from class TIIPredicate, and implemented verification rules for TIIPredicates in CodeGenSchedule.cpp.

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb updated this revision to Diff 160643.
andreadb added a comment.

Thanks for the review Matt.

I noticed that I forgot to mark the new method 'const'. So I have decided to update the code review before committing it.

Changes are:

- s/checkMCPredicates/checkMCInstPredicates
- add "const" to method `checkMCInstPredicates`
- add "const" to the Record* in the foreach loop

The rest should be identical.
If okay for you, then I would commit this version.

Sorry for the confusion and thanks in advance.

-Andrea


https://reviews.llvm.org/D50708

Files:
  include/llvm/Target/TargetInstrPredicate.td
  lib/Target/X86/X86SchedPredicates.td
  utils/TableGen/CodeGenSchedule.cpp
  utils/TableGen/CodeGenSchedule.h
  utils/TableGen/InstrInfoEmitter.cpp
  utils/TableGen/PredicateExpander.cpp
  utils/TableGen/PredicateExpander.h
  utils/TableGen/SubtargetEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50708.160643.patch
Type: text/x-patch
Size: 9546 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180814/a185d18f/attachment.bin>