[PATCH] D50650: [MemorySSA] Add API to update an incoming block into a MemoryPhi.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea abandoned this revision.
asbirlea marked an inline comment as done.
asbirlea added a comment.

Ack, using the generic one. I can revisit this if, once used, profiling shows a significant difference.



================
Comment at: include/llvm/Analysis/MemorySSAUpdater.h:127
                                Instruction *Start);
   /// BasicBlock Old had New, an empty BasicBlock, added directly before it,
   /// and the predecessors in Preds that used to point to Old, now point to
----------------
george.burgess.iv wrote:
> (If we do drop the new API, do the users of replacePhiIncomingBlock guarantee that ReplaceWith is empty? I assume so, but if not, might want to rephrase this -- feel free to do so with post-commit review :) )
Yes, ReplaceWith is empty.


Repository:
  rL LLVM

https://reviews.llvm.org/D50650