[PATCH] D50650: [MemorySSA] Add API to update an incoming block into a MemoryPhi.

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv added a comment.

> George, let me know if you agree with using the generic one and I'll abandon this revision. Thanks!

Unless profiling shows that it makes a difference, I'm in favor of using the generic impl for simplicity/code reuse, too.

Thanks for the patch!



================
Comment at: include/llvm/Analysis/MemorySSAUpdater.h:127
                                Instruction *Start);
   /// BasicBlock Old had New, an empty BasicBlock, added directly before it,
   /// and the predecessors in Preds that used to point to Old, now point to
----------------
(If we do drop the new API, do the users of replacePhiIncomingBlock guarantee that ReplaceWith is empty? I assume so, but if not, might want to rephrase this -- feel free to do so with post-commit review :) )


Repository:
  rL LLVM

https://reviews.llvm.org/D50650